Remove operator-sdk new|add api commands and ansible scaffolding.

This commit does the following:
1. Remove operator-sdk new  and operator-sdk add api in favour of ansible plugins.
2. Remove ansible scaffolding (ie) internal/scaffold/ansible.
3. Remove internal/flags/apiflags/flags.go  and relevant tests which were used in the commands.
4. Update IsOperatorAnsible() to check only for new layouts.
5. Remove hack/tests/e2e-ansible-molecule.sh and rewrite hack/tests/e2e-ansible.sh (which will get updated after ansible plugins).

changelog/fragments/rm-cmd-legacy-ansible.yaml

@@ -0,0 +1,33 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      The commands `operator-sdk new --type=ansible` and `operator-sdk add api` are no longer supported for Ansible-based Operators.
+
+    # kind is one of:
+    # - addition
+    # - change
+    # - deprecation
+    # - removal
+    # - bugfix
+    kind: "removal"
+
+    # Is this a breaking change?
+    breaking: true
+
+    # NOTE: ONLY USE `pull_request_override` WHEN ADDING THIS
+    # FILE FOR A PREVIOUSLY MERGED PULL_REQUEST!
+    #
+    # The generator auto-detects the PR number from the commit
+    # message in which this file was originally added.
+    #
+    # What is the pull request number (without the "#")?
+    # pull_request_override: 0
+
+
+    # Migration can be defined to automatically add a section to
+    # the migration guide. This is required for breaking changes.
+    migration:
+      header: New and api subcommands are no longer supported for Ansible-based Operators.
+      body: >
+        TBD

cmd/operator-sdk/add/cmd.go

@@ -25,7 +25,6 @@ func NewCmd() *cobra.Command {
 		Long:  "",
 	}
 
-	cmd.AddCommand(newAddAPICmd())
 	cmd.AddCommand(newAddCRDCmd())
 	return cmd
 }

cmd/operator-sdk/cli/cli.go

@@ -20,7 +20,6 @@ import (
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/cleanup"
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/completion"
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/generate"
-	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/new"
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/olm"
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/run"
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/scorecard"
@@ -38,9 +37,6 @@ import (
 )
 
 var commands = []*cobra.Command{
-	// The "new" cmd provides a way to scaffold Helm/Ansible projects
-	// from the new CLI.
-	new.NewCmd(),
 	scorecard.NewCmd(),
 	build.NewCmd(),
 	bundle.NewCmd(),

cmd/operator-sdk/cli/legacy.go

@@ -19,10 +19,8 @@ import (
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 
-	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/add"
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/build"
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/completion"
-	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/new"
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/olm"
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/scorecard"
 	"github.com/operator-framework/operator-sdk/cmd/operator-sdk/version"
@@ -61,11 +59,9 @@ func GetCLIRoot() *cobra.Command {
 	}
 
 	root.AddCommand(
-		add.NewCmd(),
 		build.NewCmd(),
 		scorecard.NewCmd(),
 		completion.NewCmd(),
-		new.NewCmd(),
 		olm.NewCmd(),
 		version.NewCmd(),
 	)
@@ -95,7 +91,6 @@ func checkGoModulesForCmd(cmd *cobra.Command) (err error) {
 }
 
 var commandsToSkip = map[string]struct{}{
-	"new":          struct{}{}, // Handles this logic in cmd/operator-sdk/new
 	"operator-sdk": struct{}{}, // Alias for "help"
 	"help":         struct{}{},
 	"completion":   struct{}{},

cmd/operator-sdk/main.go

@@ -58,7 +58,6 @@ func main() {
 	}
 
 	// Run the KB CLI when not running in either legacy or new projects
-	// The new CLI still supports "operator-sdk new --type=Ansible/Helm"
 	if err := cli.Run(); err != nil {
 		log.Fatal(err)
 	}