Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/operator-sdk/run: remove legacy run subcommand #3406

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Jul 13, 2020

Description of the change:
Remove the legacy run subcommand. This also incidentally removes support for run local for legacy Ansible and Helm projects

Motivation for the change:
To remove legacy code in preparation for 1.0 release.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@hasbro17
Copy link
Contributor

We have some links in the CHANGELOG referencing ./website/content/en/docs/cli/operator-sdk_run.md.
https://github.com/operator-framework/operator-sdk/blob/master/CHANGELOG.md#v0150

We could update those to be non-relative links https://v0-18-x.sdk.operatorframework.io/docs/cli/operator-sdk_run/

Or just use the git sha if we don't want to point to the website in such an older release.

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove this check and these lines. Also it looks like a reference to the removed CLI doc for run still exists somewhere.

@hasbro17
Copy link
Contributor

hasbro17 commented Jul 13, 2020

Ah this gets rid of run packagemanifests as well. Great, I don't have to push my PR now :)

@estroz estroz added this to the v1.0.0 milestone Jul 13, 2020
@joelanford joelanford force-pushed the rm-legacy-run branch 2 times, most recently from 1cf804e to b8c19f4 Compare July 13, 2020 20:52
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@joelanford
Copy link
Member Author

@hasbro17 🤣 Sorry, I got overzealous.

I updated the links to point to the docs as they existed at the time when they were referenced (so to our old github docs at the v0.15.0 tag)

@joelanford
Copy link
Member Author

I also went ahead and removed legacy cleanup command support with the same changes that @estroz suggested.

@hasbro17
Copy link
Contributor

Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasbro17
Copy link
Contributor

Per offline discussion, this needs a CHANGELOG fragment so we can track and summarize all CLI changes in the 1.0.0 release notes.

@joelanford
Copy link
Member Author

joelanford commented Jul 13, 2020

If CI passes on this commit, let's just merge and I'll do a fragment follow-up. I need to do one for #3385 as well.

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@joelanford joelanford merged commit 2594430 into operator-framework:master Jul 14, 2020
@joelanford joelanford deleted the rm-legacy-run branch July 14, 2020 01:37
# release notes and/or the migration guide
entries:
- description: >
Remove legacy run amd cleanup commands
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amd -> and

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants