Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg/tls #3468

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Remove pkg/tls #3468

merged 2 commits into from
Jul 20, 2020

Conversation

hasbro17
Copy link
Contributor

Description of the change:
Remove pkg/tls since that pkg is a left over from earlier efforts to make certificate management easier before we agreed to separate concerns and handle certificate management outside of the SDK.

Motivation for the change:
Related to #3327 in prep for removing public pkgs from the CLI repo for v1.0.0.

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@estroz
Copy link
Member

estroz commented Jul 20, 2020

@hasbro17 since they're related, can you close #396 with a comment about using cert-manager once this PR is merged?

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@joelanford
Copy link
Member

Add a fragment to remind us we removed this?

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@hasbro17 hasbro17 merged commit 650b85c into operator-framework:master Jul 20, 2020
@hasbro17 hasbro17 deleted the remove-tls-pkg branch July 20, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants