scorecard - lookup namespace from kubeconfig #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
reviewed
Jul 21, 2020
| "testing" | ||
| ) | ||
|
|
||
| func TestGetKubeNamespace(t *testing.T) { |
There was a problem hiding this comment.
Nit: we should be writing all new tests with ginkgo/gomega. But let's get this merged and add a TODO.
estroz
reviewed
Jul 21, 2020
|
|
||
| ns, _, err := kubeConfig.Namespace() | ||
| if err != nil { | ||
| return "default" |
There was a problem hiding this comment.
The "default" namespace might not exist, and we probably shouldn't mask this error so I would return it to the CLI. On the flip side, then this would be a breaking change, although I don't think that matters too much because this command was still in alpha in the most recent release.
estroz
reviewed
Jul 21, 2020
Comment on lines
+69
to
+72
|
|
||
| if kubeconfigPath != "" { | ||
| rules.ExplicitPath = kubeconfigPath | ||
| } |
There was a problem hiding this comment.
Nit:
Suggested change
| if kubeconfigPath != "" { | |
| rules.ExplicitPath = kubeconfigPath | |
| } | |
| rules.ExplicitPath = kubeconfigPath |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
add logic in scorecard command to lookup the namespace, if not set on the command line, from the
kubeconfig
Motivation for the change:
Closes #3422
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs