Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow fragments to end in either .yml or .yaml #3493

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Jul 22, 2020

Description of the change:
Allow changelog fragments to end in either .yaml or .yml

Motivation for the change:
Some fragments were being added with .yml extensions which caused make test-sanity to report the following warnings:

+ go run ./hack/generate/changelog/gen-changelog.go -validate-only
WARN[0000] Skipping non-YAML file "ansible-metrics-addr.yml" 
WARN[0000] Skipping non-YAML file "rm-ansible-metrics.yml" 

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@jmrodri
Copy link
Member Author

jmrodri commented Jul 22, 2020

With the changes in this PR, the warnings are now gone:

$ make test-sanity
...
+ go run ./hack/generate/changelog/gen-changelog.go -validate-only
+ git diff --exit-code

@joelanford joelanford mentioned this pull request Jul 22, 2020
92 tasks
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@jmrodri jmrodri merged commit e97ccb8 into operator-framework:master Jul 22, 2020
@jmrodri jmrodri deleted the allow-yml-fragments branch August 17, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants