docs: fix broken links (CI) #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
commented
Jul 24, 2020
| @@ -231,38 +238,7 @@ func contains(list []string, s string) bool { | |||
| During the lifecycle of an operator it's possible that there may be more than 1 instance running at any given time e.g when rolling out an upgrade for the operator. | |||
| In such a scenario it is necessary to avoid contention between multiple operator instances via leader election so that only one leader instance handles the reconciliation while the other instances are inactive but ready to take over when the leader steps down. | |||
|
|
|||
| There are two different leader election implementations to choose from, each with its own tradeoff. | |||
There was a problem hiding this comment.
just removed the part of the sdk impl and all the rest of the texts were kept in the same way.
camilamacedo86
commented
Jul 24, 2020
| the following link was comment for do no broke the CI | ||
| this impl probably will came from operator-lib | ||
| however, we also need to check if we would not like to just let them use | ||
| https://github.com/kubernetes/kubernetes/pull/92717/files | ||
| [godoc-conditions]: https://godoc.org/github.com/operator-framework/operator-sdk/pkg/status#Conditions |
There was a problem hiding this comment.
this one is falling now. I am not sure if we will still providing or not the helper in via operator-lib so just comment and raised : #3515
joelanford
requested changes
Jul 24, 2020
camilamacedo86
changed the title
joelanford
reviewed
Jul 24, 2020
Comment on lines
31
to
35
| <!-- todo(camilamacedo) | ||
| the following link was comment for do no broke the CI | ||
| this impl probably will came from operator-lib | ||
| however, we also need to check if we would not like to just let them use | ||
| https://github.com/kubernetes/kubernetes/pull/92717/files |
There was a problem hiding this comment.
pkg/status was also moved to operator-lib. Let's just update that link as well.
And I don't think this is the appropriate place for a comment about the choice of implementations to use.
I think a better choice would be to open an issue in operator-lib asking whether it makes sense to deprecate status and point users to k8s.io/apimachinery's implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
docs: fix broken links (CI)
Motivation for the change:
fix CI and 1.0.0