Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removal: cleanup over legacy support #3539

Merged
merged 4 commits into from
Jul 30, 2020
Merged

removal: cleanup over legacy support #3539

merged 4 commits into from
Jul 30, 2020

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jul 25, 2020 •
edited
Loading

Description of the change:
Follow-up of #3533

Motivation for the change:

Blocked by : #3433

@camilamacedo86 camilamacedo86 force-pushed the remove-legacy branch 3 times, most recently from a35dc66 to c2ec6b7 Compare July 25, 2020 10:10
@camilamacedo86 camilamacedo86 mentioned this pull request Jul 25, 2020
Closed
This was referenced Jul 25, 2020
Merged
Closed
estroz
estroz suggested changes Jul 25, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is effectively doing the same thing as #3533, although no tests should be removed (ansible-molecule) to make this pass. #3433 should be merged first.

@camilamacedo86

This comment has been minimized.

Sign in to view
@varshaprasad96 varshaprasad96 mentioned this pull request Jul 26, 2020
Merged
2 tasks
@camilamacedo86 camilamacedo86 changed the title removal: support to the legacy projects WIP: removal: support to the legacy projects Jul 27, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2020
@camilamacedo86 camilamacedo86 changed the title WIP: removal: support to the legacy projects removal: support to the legacy projects Jul 27, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2020
@camilamacedo86 camilamacedo86 added blocked kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 27, 2020
@camilamacedo86
Copy link
Contributor Author

I flagged as blocked this one in favor of #3533 eric's pr's.
However, I will not close this one because it shows as points not done in #3533. The idea here is:

c/c @estroz

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2020
@camilamacedo86 camilamacedo86 changed the title removal: support to the legacy projects removal: cleanup over legacy support Jul 30, 2020
@camilamacedo86
Copy link
Contributor Author

@joelanford rebased with the master.

joelanford
joelanford approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
estroz
estroz approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@camilamacedo86 camilamacedo86 merged commit 6bcaff8 into operator-framework:master Jul 30, 2020
@camilamacedo86 camilamacedo86 deleted the remove-legacy branch July 30, 2020 17:15
camilamacedo86 added a commit to camilamacedo86/operator-sdk that referenced this pull request Jul 30, 2020
@camilamacedo86
removal: cleanup over legacy support (operator-framework#3539)
b563410 
Follow-up of operator-framework#3533
camilamacedo86 added a commit to camilamacedo86/operator-sdk that referenced this pull request Jul 30, 2020
@camilamacedo86
removal: cleanup over legacy support (operator-framework#3539)
bae2ca5 
Follow-up of operator-framework#3533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@estroz estroz estroz approved these changes

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@jmrodri jmrodri Awaiting requested review from jmrodri

@fabianvf fabianvf Awaiting requested review from fabianvf

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@joelanford joelanford

@estroz estroz

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camilamacedo86 @joelanford @estroz @openshift-ci-robot