Add back setting environment variable #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+126
to
+130
| err = setAnsibleEnvVars(f) | ||
| if err != nil { | ||
| log.Error(err, "Failed to set environment variable.") | ||
| os.Exit(1) | ||
| } |
There was a problem hiding this comment.
Suggested change
| err = setAnsibleEnvVars(f) | |
| if err != nil { | |
| log.Error(err, "Failed to set environment variable.") | |
| os.Exit(1) | |
| } | |
| if err := setAnsibleEnvVars(f); err != nil { | |
| log.Error(err, "Failed to set environment variable.") | |
| os.Exit(1) | |
| } |
| "value", f.AnsibleCollectionsPath) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
I agree. Shows that it should be kept. @fabianvf @asmacdo @jmrodri @joelanford wdyt?
camilamacedo86
added
the
language/ansible
|
Great catch @tengqm! Thanks! This was actually released in v0.19.0, so we'll need to backport this. Because of this, can you please add a CHANGELOG fragment? |
The commit 'ed92d3668ca921270d01055d8d8e01f3fd5187d3' removed the `setAnsibleEnvVars` function. However, that function is important to make sure the command line flags `ansible-roles-path` and `ansible-collections-path` work. These command line flags are set into environment variables that will be picked up later.
joelanford
force-pushed
the
ansible-operator-env
branch
from
914466c
to
1bf89f7
Compare
|
/lgtm |
|
/cherry-pick v0.19.x |
|
@joelanford: #3549 failed to apply on top of branch "v0.19.x": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
The commit
ed92d3668ca921270d01055d8d8e01f3fd5187d3removed thesetAnsibleEnvVarsfunction. However, that function is important to make sure the command line flagsansible-roles-pathandansible-collections-pathwork. These command line flags are set into environment variables that will be picked up later.Motivation for the change:
This PR fixes an issue introduced by a previous PR.
Not sure we need a change log for this kind of fix, because it is fixing a bug that is not yet released.