Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: quickstart for Ansible projects #3555

Merged
merged 2 commits into from
Jul 27, 2020
Merged

doc: quickstart for Ansible projects #3555

merged 2 commits into from
Jul 27, 2020

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jul 26, 2020 •
edited
Loading

Description of the change:

  • The quickstart was moved to tutorial
  • Added new quickstart less verbose and with the concise steps.
  • Update the links and the order to show the docs

See: https://deploy-preview-3555--operator-sdk.netlify.app/docs/building-operators/ansible/quickstart/

Motivation for the change:

#3327
Closes: #2774

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2020
@joelanford joelanford mentioned this pull request Jul 26, 2020
Closed
92 tasks
@camilamacedo86 camilamacedo86 changed the title wip: doc: add ansible quickstart wip: doc: quickstart for Helm projects Jul 26, 2020
@camilamacedo86 camilamacedo86 changed the title wip: doc: quickstart for Helm projects wip: doc: quickstart for Ansible projects Jul 26, 2020
@camilamacedo86 camilamacedo86 changed the title wip: doc: quickstart for Ansible projects doc: quickstart for Ansible projects Jul 26, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2020
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jul 26, 2020 •
edited
Loading

Hi @fabianvf @asmacdo @jmrodri

I did it equals the others. Also, IMO I cannot test all steps because of #3556 but I think we can move forward here and after perform an follow up if required. wdyt?

@camilamacedo86 camilamacedo86 mentioned this pull request Jul 27, 2020
Closed
@camilamacedo86 camilamacedo86 added this to the v1.0.0 milestone Jul 27, 2020
@camilamacedo86 camilamacedo86 added language/ansible Issue is related to an Ansible operator project kind/documentation Categorizes issue or PR as related to documentation. labels Jul 27, 2020
@camilamacedo86 camilamacedo86 force-pushed the quick-ansible branch 2 times, most recently from 628626b to c967837 Compare July 27, 2020 13:43
asmacdo
asmacdo suggested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change.

website/content/en/docs/building-operators/ansible/quickstart.md Show resolved Hide resolved
website/content/en/docs/building-operators/ansible/tutorial.md Show resolved Hide resolved
jmrodri
jmrodri approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@camilamacedo86 camilamacedo86 merged commit b468973 into operator-framework:master Jul 27, 2020
@camilamacedo86 camilamacedo86 deleted the quick-ansible branch July 27, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@asmacdo asmacdo asmacdo approved these changes

@fabianvf fabianvf Awaiting requested review from fabianvf

Assignees

@jmrodri jmrodri

Labels
kind/documentation Categorizes issue or PR as related to documentation. language/ansible Issue is related to an Ansible operator project lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Improve Ansible User Guide documentation for Building/Running the Operator
4 participants
@camilamacedo86 @jmrodri @asmacdo @openshift-ci-robot