Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cmd APIs to internal/cmd/operator-sdk/ #3568

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Move cmd APIs to internal/cmd/operator-sdk/ #3568

merged 1 commit into from
Jul 27, 2020

Conversation

hasbro17
Copy link
Contributor

@hasbro17 hasbro17 commented Jul 27, 2020 •
edited
Loading

Description of the change:
Move public cmd pkgs in cmd/operator-sdk/* to internal/cmd/operator-sdk/*.

Motivation for the change:
Remove public APIs from operator-sdk CLI repo #3327

@hasbro17
Copy link
Contributor Author

Forgot about hack/generate/cli-doc/gen-cli-doc not being able to use cmd/operator-sdk/internal/cli.
Going to move cmd/operator-sdk/* to internal/cmd/operator-sdk/*

joelanford
joelanford approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
varshaprasad96
varshaprasad96 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hasbro17 hasbro17 changed the title Move cmd APIs to cmd/operator-sdk/internal Move cmd APIs to internal/cmd/operator-sdk/ Jul 27, 2020
@hasbro17 hasbro17 merged commit 4054b5f into operator-framework:master Jul 27, 2020
@hasbro17 hasbro17 deleted the add-cmd-internal branch July 27, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@fabianvf fabianvf Awaiting requested review from fabianvf

@estroz estroz Awaiting requested review from estroz

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

Assignees

@joelanford joelanford

@varshaprasad96 varshaprasad96

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hasbro17 @joelanford @varshaprasad96 @openshift-ci-robot