-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<run|cleanup> packagemanifests: remove --olm-namespace
, change --operator-namespace
to --namespace
#3601
<run|cleanup> packagemanifests: remove --olm-namespace
, change --operator-namespace
to --namespace
#3601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
after fixing typo in log message and CI passes
60dd523
to
6265bd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -0,0 +1,15 @@ | |||
entries: | |||
- description: Removed the `--olm-namespace` flag from `run packagemanifests`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to using the past tense, Removed
, it reads better when the changelog is generated.
header: Remove `--olm-namespace` from `run packagemanifests` invocations | ||
body: > | ||
OLM namespace is no longer required by this command. | ||
- description: Changed the `--operator-namespace` flag to `--namespace` in `run packagemanifests`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@estroz test broke
|
One clarification: we probably need to change this from |
…ed since it is no longer used by the command, and `--operator-namespace` has been renamed to `--namespace`.
6265bd4
to
af455e1
Compare
New changes are detected. LGTM label has been removed. |
Description of the change:
Motivation for the change:
<run|cleanup packagemanifests
flag--olm-namespace
has been removed since it is no longer used by the command, and--operator-namespace
has been renamed to--namespace
. OLM-adjacent resources (ex. registry deployment) are now created in the provided namespace, and OLM installation is no longer checked./cc @joelanford @jmrodri @rashmigottipati
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs