Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump operator-registry to v1.13.4 #3602

Merged
merged 1 commit into from
Jul 29, 2020
Merged

deps: bump operator-registry to v1.13.4 #3602

merged 1 commit into from
Jul 29, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 29, 2020

Description of the change: bump operator-registry to v1.13.4

Motivation for the change: this version of operator-registry removes default channel validation and the need for the gopkg.in/yaml dependency

/cc @dinhxuanvu @joelanford @shawn-hurley

/area dependency

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci-robot openshift-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jul 29, 2020
@joelanford joelanford mentioned this pull request Jul 29, 2020
Closed
92 tasks
dinhxuanvu
dinhxuanvu approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
joelanford
joelanford approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@estroz estroz force-pushed the deps/bump-operator-registry-v1.13.4 branch from 49f2331 to 50da1ab Compare July 29, 2020 21:28
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 29, 2020
camilamacedo86
camilamacedo86 reviewed Jul 29, 2020
View reviewed changes
go.mod
@@ -27,8 +27,6 @@ require (
go.uber.org/zap v1.14.1
golang.org/x/tools v0.0.0-20200403190813-44a64ad78b9b
gomodules.xyz/jsonpatch/v3 v3.0.1
gopkg.in/yaml.v2 v2.3.0
gopkg.in/yaml.v3 v3.0.0-20190905181640-827449938966
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loved 👍

camilamacedo86
camilamacedo86 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
dinhxuanvu
dinhxuanvu approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@estroz estroz force-pushed the deps/bump-operator-registry-v1.13.4 branch from 50da1ab to 50493b4 Compare July 29, 2020 21:40
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 29, 2020
dinhxuanvu
dinhxuanvu approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@dinhxuanvu dinhxuanvu removed their assignment Jul 29, 2020
@estroz estroz mentioned this pull request Jul 29, 2020
Merged
@estroz estroz merged commit a383aa5 into operator-framework:master Jul 29, 2020
@estroz estroz deleted the deps/bump-operator-registry-v1.13.4 branch July 29, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@joelanford joelanford joelanford approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@joelanford joelanford

@camilamacedo86 camilamacedo86

Labels
area/dependency Issues or PRs related to dependency changes lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estroz @joelanford @camilamacedo86 @dinhxuanvu @openshift-ci-robot