ansible/helm : align flags and deprecate the old ones #4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
commented
Mar 16, 2021
| # endpoint w/o any authn/z, please comment the following line. | ||
| # Protect the /metrics endpoint by putting it behind auth. | ||
| # If you want your controller-manager to expose the /metrics | ||
| # endpoint w/o any authn/z, please comment the following line. |
There was a problem hiding this comment.
these changes are because of the alignment to keep the file such as upstream.
camilamacedo86
commented
Mar 16, 2021
| &prometheus.Kustomization{}, | ||
| &prometheus.ServiceMonitor{}, | ||
| &kdefault.AuthProxyPatch{}, | ||
| &kdefault.ManagerAuthProxyPatch{}, |
There was a problem hiding this comment.
these changes are because of the alignment to keep the file such as upstream.
just replace the names
camilamacedo86
commented
Mar 16, 2021
| type Kustomization struct { | ||
| file.TemplateMixin | ||
| } | ||
|
|
||
| // SetTemplateDefaults implements input.Template | ||
| // SetTemplateDefaults implements file.Template | ||
| func (f *Kustomization) SetTemplateDefaults() error { |
There was a problem hiding this comment.
these changes are because of the alignment to keep the file such as upstream.
camilamacedo86
commented
Mar 16, 2021
| // Manager scaffolds yaml config for the manager. | ||
| type Manager struct { | ||
| // Config scaffolds a file that defines the namespace and the manager deployment | ||
| type Config struct { |
There was a problem hiding this comment.
these changes are because of the alignment to keep the file such as upstream.
|
Hi @estroz, Really thank you. All suggestion (less this nit #4654 (comment)) are addressed, PLease, feel free to check. |
estroz
suggested changes
Mar 18, 2021
| # release notes and/or the migration guide | ||
| entries: | ||
| - description: > | ||
| (ansible/v1)(helm/v1) In order to align the Ansible/Helm based-projects with the Kubernetes nomenclatures the flags `--enable-leader-election` and `--metrics-addr` were deprecated and replaced by `--leader-elect` and `--metrics-bind-address` respectively. |
There was a problem hiding this comment.
Suggested change
| (ansible/v1)(helm/v1) In order to align the Ansible/Helm based-projects with the Kubernetes nomenclatures the flags `--enable-leader-election` and `--metrics-addr` were deprecated and replaced by `--leader-elect` and `--metrics-bind-address` respectively. | |
| (ansible/v1, helm/v1) The flags `--enable-leader-election` and `--metrics-addr` were deprecated in favor of `--leader-elect` and `--metrics-bind-address`, respectively, to follow upstream conventions. |
| # Migration can be defined to automatically add a section to | ||
| # the migration guide. This is required for breaking changes. | ||
| migration: | ||
| header: (ansible/v1)(helm/v1) Replace the deprecated flags |
There was a problem hiding this comment.
Suggested change
| header: (ansible/v1)(helm/v1) Replace the deprecated flags | |
| header: (ansible/v1, helm/v1) Replace deprecated leader election and metrics address flags |
| migration: | ||
| header: (ansible/v1)(helm/v1) Replace the deprecated flags | ||
| body: > | ||
| Replace the flags `--enable-leader-election` and `--metrics-addr` which were deprecated with `--leader-elect` and `--metrics-bind-address` respectively. |
There was a problem hiding this comment.
Suggested change
| Replace the flags `--enable-leader-election` and `--metrics-addr` which were deprecated with `--leader-elect` and `--metrics-bind-address` respectively. | |
| Replace deprecated flags `--enable-leader-election` and `--metrics-addr` with `--leader-elect` and `--metrics-bind-address`, respectively. |
| body: > | ||
| Replace the flags `--enable-leader-election` and `--metrics-addr` which were deprecated with `--leader-elect` and `--metrics-bind-address` respectively. | ||
| - description: > | ||
| (ansible/v1)(helm/v1) Ensure that the `--health-probe-bind-address` port will be informed to the proxy. |
There was a problem hiding this comment.
Suggested change
| (ansible/v1)(helm/v1) Ensure that the `--health-probe-bind-address` port will be informed to the proxy. | |
| (ansible/v1, helm/v1) Explicitly set `--health-probe-bind-address` in the manager's auth proxy patch. |
| # - deprecation | ||
| # - removal | ||
| # - bugfix | ||
| kind: "bugfix" |
There was a problem hiding this comment.
This is more of a non-breaking change, since nothing is currently broken.
Suggested change
| kind: "bugfix" | |
| kind: "change" |
| # Migration can be defined to automatically add a section to | ||
| # the migration guide. This is required for breaking changes. | ||
| migration: | ||
| header: (ansible/v1)(helm/v1) Ensure that the `--health-probe-bind-address` port will be informed to the proxy. |
There was a problem hiding this comment.
Suggested change
| header: (ansible/v1)(helm/v1) Ensure that the `--health-probe-bind-address` port will be informed to the proxy. | |
| header: (ansible/v1, helm/v1) Explicitly set `--health-probe-bind-address` in the manager's auth proxy patch. |
Signed-off-by: Camila Macedo <[email protected]>
|
@estroz All done tks. |
waynesun09
added a commit
to waynesun09/reportportal-operator
that referenced
this pull request
Apr 22, 2021
This is related to upgrade operator-sdk to v1.6.0: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.6.0/ operator-framework/operator-sdk#4654 Signed-off-by: Wayne Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs