Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#54503] added 5 more icons for usage in 3d viewer #50

Merged
merged 4 commits into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-foxes-shake.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@openproject/octicons': minor
---

Added 5 new icons for 3d viewer actions
29 changes: 15 additions & 14 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,21 +52,19 @@ attributes, as those are removed by the CI step "Optimize SVGs".
```

### 5. Create and push a changeset
For release dependent Pull Requests, add a changeset file to your Pull Request. These files are needed for the release process managed by [Changesets](https://github.com/changesets/changesets#readme).
For release dependent Pull Requests, add a changeset file to your Pull Request. These files are needed for the release
process managed by [Changesets](https://github.com/changesets/changesets#readme).

1. Install (if you have not done before)
```shell
npm install @changesets/cli && npx changeset init
```

```shell
npm install @changesets/cli && npx changeset init
```
2. Create a changeset
```shell
npx changeset
```

```shell
npx changeset
```
3. Select version type (patch, minor, major)
4. Type a message explaining your changes (equivalent to release notes)

4. Type a message explaining your changes (equivalent to release notes)

### 6. Commit and push changes

Expand All @@ -78,13 +76,16 @@ git push

### 7. Create a pull request

Use GitHub to [create a pull request](https://help.github.com/en/desktop/contributing-to-projects/creating-a-pull-request) for your branch. In your pull request description, be sure to mention where the icon will be used and any relevant timeline information.
Use GitHub to [create a pull request](https://help.github.com/en/desktop/contributing-to-projects/creating-a-pull-request) for your branch. In your pull request description, be sure to mention where
the icon will be used and any relevant timeline information.

If everything looks good, a maintainer will approve and merge the pull request when appropriate. After the pull request is merged, your icon will be available in the next Octicons release.
If everything looks good, a maintainer will approve and merge the pull request when appropriate. After the pull request
is merged, your icon will be available in the next Octicons release.


## Other contributions

When contributing to Octicons outside of adding a new icon or release-dependent contribution, you don't have to add a _Changeset_ file.
When contributing to Octicons outside of adding a new icon or release-dependent contribution, you don't have to add a
_Changeset_ file.

Examples of other contributions include adding documentation or improving a GitHub Actions workflows.
1 change: 1 addition & 0 deletions icons/op-first-person-view-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/op-orthographic-perspective-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/op-threed-return-default-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/op-view-fit-to-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/op-view-threed-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions keywords.json
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,12 @@
"op-cursor-rectangle-select": ["group", "select"],
"op-cursor-select": ["pointer", "select", "mouse"],
"op-erase": ["remove", "delete"],
"op-first-person": ["person", "human", "ego-perspective"],
"op-orthographic-perspective": ["3d", "threed", "camera", "view"],
"op-scissors": ["cut", "snip", "slice", "clip"],
"op-threed-return-default": ["reset", "cube"],
"op-view-fit-to": ["rectangle", "fit", "frame", "view"],
"op-view-threed": ["3d", "threed"],
"organization": ["people", "group", "team"],
"package": ["box", "ship"],
"paintcan": ["style", "theme", "art", "color"],
Expand Down
Loading