Merge pull request #14436 from opf/bug/51374-notes-on-add-work-packag…

…e-to-meeting-modal-are-overflowing [51374] Notes on Add work package to meeting modal are overflowing
opf · Dec 18, 2023 · 72378fe · 72378fe
2 parents f440c9e + 123ea81
commit 72378fe
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/modules/meeting/app/components/meetings/sidebar/participants_form_component.html.erb b/modules/meeting/app/components/meetings/sidebar/participants_form_component.html.erb
@@ -1,13 +1,14 @@
 <%=
   content_tag("turbo-frame", id: "edit-participants-dialog-frame") do
-    component_wrapper do
+    component_wrapper(class: 'Overlay-form') do
       primer_form_with(
         model: @meeting,
         method: :put,
-        url: update_participants_meeting_path(@meeting)
+        url: update_participants_meeting_path(@meeting),
+        class: 'Overlay-form'
       ) do |f|
         component_collection do |collection|
-          collection.with_component(Primer::Alpha::Dialog::Body.new(style: "max-height: 460px;", my: 3)) do
+          collection.with_component(Primer::Alpha::Dialog::Body.new(my: 3)) do
             flex_layout(mt: 3) do |form_container|
               form_container.with_row do
                 flex_layout(justify_content: :flex_end) do |header|

diff --git a/modules/meeting/app/components/op_turbo/op_primer/async_dialog_component.html.erb b/modules/meeting/app/components/op_turbo/op_primer/async_dialog_component.html.erb
@@ -14,6 +14,7 @@
                   id: "#{@id}-frame",
                   loading: :lazy,
                   src: @src,
+                  class: 'Overlay-form',
                   data: { 'op-turbo-op-primer-async-dialog-target': "frameElement" }) do
         flex_layout(justify_content: :center) do |flex|
           flex.with_column(my: 5) do

diff --git a/.../components/work_package_meetings_tab/add_work_package_to_meeting_form_component.html.erb b/.../components/work_package_meetings_tab/add_work_package_to_meeting_form_component.html.erb
@@ -1,10 +1,11 @@
 <%=
   content_tag("turbo-frame", id: "add-work-package-to-meeting-dialog-frame") do
-    component_wrapper do
+    component_wrapper(class: 'Overlay-form') do
       primer_form_with(
         model: @meeting_agenda_item,
         method: :post,
-        url: work_package_meeting_agenda_items_path(@work_package)
+        url: work_package_meeting_agenda_items_path(@work_package),
+        class: 'Overlay-form'
       ) do |f|
         component_collection do |collection|
           collection.with_component(Primer::Alpha::Dialog::Body.new(test_selector: 'op-add-work-package-to-meeting-dialog-body')) do