Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#50684] Migrate to httpx http ruby client #13986

Merged
merged 13 commits into from
Jan 10, 2024

Conversation

ba1ash
Copy link
Member

@ba1ash ba1ash commented Oct 24, 2023

https://community.openproject.org/work_packages/50684
It is a draft. I migrated nextcloud queries/command to use HTTPX.

@ba1ash ba1ash self-assigned this Oct 24, 2023
@ba1ash ba1ash force-pushed the task/50684-migrate-to-httpx-http-ruby-client branch from 62328f8 to 26d3e2f Compare October 25, 2023 12:26
@mereghost
Copy link
Contributor

I like it. Well... liking something more than Net:HTTP isn't that much of a high bar to set, but it looks nice.

@mereghost mereghost force-pushed the task/50684-migrate-to-httpx-http-ruby-client branch from 26d3e2f to 8226087 Compare December 4, 2023 10:15
@ba1ash ba1ash force-pushed the task/50684-migrate-to-httpx-http-ruby-client branch from 0fb7f4d to 89e4d06 Compare December 19, 2023 13:13
@ba1ash ba1ash requested review from mereghost and a team December 19, 2023 14:28
@ba1ash ba1ash marked this pull request as ready for review December 19, 2023 14:29
@ba1ash ba1ash force-pushed the task/50684-migrate-to-httpx-http-ruby-client branch from f2793aa to c22721c Compare December 22, 2023 09:22
Copy link
Contributor

@mereghost mereghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nice work here, this lays down the groundwork for even bigger changes. \o/

@dominic-braeunlein dominic-braeunlein merged commit e10f5e1 into dev Jan 10, 2024
9 checks passed
@dominic-braeunlein dominic-braeunlein deleted the task/50684-migrate-to-httpx-http-ruby-client branch January 10, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants