-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#50684] Migrate to httpx http ruby client #13986
Merged
dominic-braeunlein
merged 13 commits into
dev
from
task/50684-migrate-to-httpx-http-ruby-client
Jan 10, 2024
Merged
[#50684] Migrate to httpx http ruby client #13986
dominic-braeunlein
merged 13 commits into
dev
from
task/50684-migrate-to-httpx-http-ruby-client
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba1ash
force-pushed
the
task/50684-migrate-to-httpx-http-ruby-client
branch
from
October 25, 2023 12:26
62328f8
to
26d3e2f
Compare
I like it. Well... liking something more than |
mereghost
force-pushed
the
task/50684-migrate-to-httpx-http-ruby-client
branch
from
December 4, 2023 10:15
26d3e2f
to
8226087
Compare
ba1ash
force-pushed
the
task/50684-migrate-to-httpx-http-ruby-client
branch
from
December 19, 2023 13:13
0fb7f4d
to
89e4d06
Compare
ba1ash
force-pushed
the
task/50684-migrate-to-httpx-http-ruby-client
branch
from
December 22, 2023 09:22
f2793aa
to
c22721c
Compare
mereghost
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nice work here, this lays down the groundwork for even bigger changes. \o/
dominic-braeunlein
deleted the
task/50684-migrate-to-httpx-http-ruby-client
branch
January 10, 2024 16:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/50684
It is a draft. I migrated nextcloud queries/command to use HTTPX.