improve the notification performance #14414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaustopher
approved these changes
Dec 13, 2023
ulferts
force-pushed
the
fix/improve_notification_performance
branch
from
77e127d
to
661c874
Compare
|
It seems to be messing with the onboarding tour. Any idea how those changes interfere? |
|
The specs got broken before this PR. @klaustopher already issued a PR for fixing those #14417. Testing the altered statements against production data indicates, that the new statement is roughly an order of magnitude faster than the old one. |
This improvements has two parts: * Avoid reapplying the visibility check for notifications. * Merging the constraints rather then having them in a subselect.
The visible scope already applies conditional constraints based on permission
ulferts
force-pushed
the
fix/improve_notification_performance
branch
from
661c874
to
8249e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improvements has two parts:
It requires moving the visibility scope of principals as that would otherwise not be applied correctly. But since the Principal's visibility scope does already apply the constraints conditionally, moving does not change the behaviour.
https://community.openproject.org/wp/51622