Allow ProjectQuery to be marked as public #15609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaustopher
force-pushed
the
public-project-lists
branch
3 times, most recently
from
c3775a3
to
5afa381
Compare
klaustopher
force-pushed
the
public-project-lists
branch
from
f4be342
to
0996000
Compare
toy
reviewed
May 22, 2024
app/contracts/queries/projects/project_queries/base_contract.rb
Outdated
Show resolved
Hide resolved
Comment on lines
+3
to
+4
| add_column :project_queries, :public, :boolean, default: false, null: false | ||
| add_index :project_queries, :public |
There was a problem hiding this comment.
Do we know if there are instances with enough projects to make this slow (presence of default value) and is it a problem?
There was a problem hiding this comment.
@ulferts Can you maybe chime in? I don't think that there are instances where we have too many project queries, that adding a default will slow us down significantly. We can always go ahead and split up the migration and add a background job to add the default value everywhere. But I suppose that this is a non issue.
Also, it seems like Postgres 11 changed the way how new columns with default values are added so it does not change every row in the table, but has a more efficient way to insert.
spec/contracts/queries/projects/project_queries/shared_contract_examples.rb
Show resolved
Hide resolved
klaustopher
force-pushed
the
public-project-lists
branch
from
518c28e
to
08b5f71
Compare
klaustopher
force-pushed
the
public-project-lists
branch
from
08b5f71
to
92a8327
Compare
toy
reviewed
May 27, 2024
toy
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the portion of making project lists public.
publicflagpublicandprivatescopes to theProjectQuerymodelmanage_public_project_queriespermission...menu to change public status of a querywhere(user:)topublic.or(private)It is intended to be a self contained spike that is not relying on the modal or anything, hence why we are temporarily adding the menu items.
Implements https://community.openproject.org/work_packages/55159