Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn menu factory project independent - move ProjectQuery services and contracts #16448

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

ulferts
Copy link
Contributor

@ulferts ulferts commented Aug 15, 2024

The goal of this PR is to start generalizing the solutions introduced for the project index page so that they can be reused for other pages as well. To that end:

  • The factory used for finding queries e.g. in the menu have become project independent. The static queries that used to be part of it are moved into their own Static class. Some tests were removed which's code was only used in the test. Since production code made no use of the code paths, the tests have been removed.
  • Services and contracts for ProjectQueries have been moved to become more railsy. This is in line with moving the ProjectQuery itself from Queries::Projects::ProjectQuery to just ProjectQuery

@ulferts ulferts force-pushed the code-maintenance/move_project_query_namespaces branch 2 times, most recently from a27fcaf to c9bf382 Compare August 15, 2024 16:03
@ulferts ulferts marked this pull request as ready for review August 16, 2024 07:12
@ulferts ulferts force-pushed the code-maintenance/move_project_query_namespaces branch from c9bf382 to 98c86b6 Compare August 16, 2024 13:10
@ulferts ulferts force-pushed the code-maintenance/move_project_query_namespaces branch 3 times, most recently from 023c30c to b83713f Compare August 22, 2024 12:24
@ulferts ulferts force-pushed the code-maintenance/move_project_query_namespaces branch from b83713f to 69f6194 Compare September 27, 2024 07:25
@ulferts ulferts merged commit 29f8097 into dev Sep 27, 2024
11 checks passed
@ulferts ulferts deleted the code-maintenance/move_project_query_namespaces branch September 27, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants