[57990] Make migration work with database from before 14.0 version #16820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbliard this should be rebased to 14.6 |
oliverguenther
approved these changes
Sep 26, 2024
I think I'll always make that mistake. EDIT: well it did, but I did not see it. |
https://community.openproject.org/wp/57990 The code to create the temporary table in common between the migration and the job to update status and % complete values. It has recently changed to get the `excluded_from_totals` value from the `statuses` table, but this field has been created in 14.2, and does not exist yet in 14.0 when this migration is run. This commit adds the previous version of the code to create the temporary table, that does not require the `excluded_from_totals` field. It also avoids creating the depths table which is not necessary in this case.
cbliard
force-pushed
the
fix/make-progress-migration-work-before-14-0
branch
from
caca6a3
to
775a526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/57990
What are you trying to accomplish?
What approach did you choose and why?
The code to create the temporary table in common between the migration and the job to update status and % complete values. It has recently changed to get the
excluded_from_totalsvalue from thestatusestable, but this field has been created in 14.2, and does not exist yet in 14.0 when this migration is run.This commit adds the previous version of the code to create the temporary table, that does not require the
excluded_from_totalsfield. It also avoids creating the depths table which is not necessary in this case.Merge checklist