Move the reference value back to the header #16838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
force-pushed
the
fix/58120/reload-banner-reference-value
branch
from
28235cc
to
5fb5ce9
Compare
|
I still have a todo to take another look at why the spec did not catch it. We trigger the flash in both windows and that should have caused it to fail. Since I won't be there next week but want it included in the next deployment, merging it as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/58120
Ticket
What are you trying to accomplish?
The meeting reference value is being automatically updated by turbo stream. We moved the poll-for-changes to the content controller, as that allows flashes to be
targetson the controller.This however breaks the reference updating. For that to work, allow a reference target to be defined instead of taking it from the value.