[#58142] Update banners to render overlayed flash with rounded borders #16843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…option https://community.openproject.org/work_packages/58142 #16640 unified the primerized flash message rendering and updated to a default overlayed flash. Hence we should remove `full: true` that is used in full width contexts which is no longer the case.
akabiru
force-pushed
the
bug/58142-update-storage-banners-to-render-with-rounded-borders
branch
from
19a2f64
to
0b9c117
Compare
akabiru
changed the title
Leverage correct pagination rendering via `url_for_action:` overrides.
ba1ash
approved these changes
Sep 30, 2024
akabiru
deleted the
bug/58142-update-storage-banners-to-render-with-rounded-borders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/58142
#16640 unified the primerized flash message rendering and updated to a default overlayed flash. Hence we should remove
full: truethat is used in full width contexts which is no longer the case.🚧 These are mainly style changes, test coverage already exists
Before
After