Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EloquentBuilderTrait.php #1

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Conversation

opichon
Copy link
Owner

@opichon opichon commented Oct 1, 2017

FIxed EloquentBuilderTrait. This is identical to PR esbenp#31, but in addition I have made the joinRelatedModelIfExists method protected. In 18 years of PHP development I have never come across any legitimate reason for making a method private. Making this method private means that it cannot be overridden. In the case of this bug in the EloquentBuilderTrait, it means that there is no easy way to override that method to fix the bug..

FIxed EloquentBuilderTrait
@opichon opichon merged commit 686b035 into master Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant