Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CreateNamespace RPC #45

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Conversation

harishp8889
Copy link
Contributor

Signed-off-by: Harish P [email protected]

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #45 (df651d5) into main (6f9332a) will increase coverage by 3.33%.
The diff coverage is 48.48%.

❗ Current head df651d5 differs from pull request most recent head 99a36b8. Consider uploading reports for the commit 99a36b8 to get more accurate results

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   31.57%   34.91%   +3.33%     
==========================================
  Files           1        1              
  Lines         171      169       -2     
==========================================
+ Hits           54       59       +5     
+ Misses        112      106       -6     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
goopicsi.go 34.91% <48.48%> (+3.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@harishp8889 harishp8889 force-pushed the feature/new_rpc branch 4 times, most recently from 77aa0f5 to efd030c Compare November 11, 2022 13:50
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVMeControllerConnect , NVMeControllerConnect and CreateNVMeNamespace should not return protobuf message as a return value. instead just string/int/error maybe

otherwise implementation and user are tightly coupled and forces user to know about protobufs. if library changes in the future to support REST, for example, the user of the library should not be affected by it...

goopicsi.go Outdated Show resolved Hide resolved
@harishp8889 harishp8889 force-pushed the feature/new_rpc branch 2 times, most recently from 48c1b58 to e5d76d9 Compare November 14, 2022 06:45
@harishp8889 harishp8889 marked this pull request as ready for review November 14, 2022 06:49
@harishp8889 harishp8889 requested a review from a team as a code owner November 14, 2022 06:49
@harishp8889
Copy link
Contributor Author

NVMeControllerConnect , NVMeControllerConnect and CreateNVMeNamespace should not return protobuf message as a return value. instead just string/int/error maybe

otherwise implementation and user are tightly coupled and forces user to know about protobufs. if library changes in the future to support REST, for example, the user of the library should not be affected by it...

Fixed

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harishp8889 harishp8889 force-pushed the feature/new_rpc branch 2 times, most recently from f5ef2e9 to 43e1fda Compare November 14, 2022 12:53
glimchb and others added 2 commits November 14, 2022 08:00
@glimchb glimchb merged commit 6150e11 into opiproject:main Nov 14, 2022
@harishp8889 harishp8889 deleted the feature/new_rpc branch November 14, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants