Fix#396 - Rename tutorials + Fix names in sidebar #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlip
requested changes
Oct 10, 2024
| @@ -1,5 +1,3 @@ | |||
| # Tutorial: Making a Simple UI Change | |||
There was a problem hiding this comment.
You've deleted the header of the page, so what is the page going to look like on the GitHub wiki? Will readers know what the page refers to?
There was a problem hiding this comment.
Github wiki automatically renders the file name as the top level header (I learnt about it just recently) - https://github.com/oppia/oppia/wiki/Making-a-simple-UI-change. If you checkout the wiki page, you could see two headers which is making it look a bit odd.
_Sidebar.md
Outdated
| @@ -52,7 +52,7 @@ | |||
| * [[Debug frontend code|Debug-frontend-code]] | |||
| * [[Debugging Stories|Debugging-Stories]] | |||
| * [[Testing email functionality|Testing-email-functionality]] | |||
| * [[Tutorial - Learn-to-figure-out-the-reproduction-steps-for-server-error|Tutorial:-Learn-to-figure-out-the-reproduction-steps-for-server-error]] | |||
| * [[Tutorial - Learn to figure out the reproduction steps for server error|Tutorial-Learn-to-Figure-Out-the-Reproduction-Steps-for-Server-Error]] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #396
Rename tutorials - Remove colons from the name of the tutorials
Fix the tutorial links name in Sidebar.