Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tranquilo #294

Merged
merged 55 commits into from
Sep 28, 2022
Merged

Tranquilo #294

merged 55 commits into from
Sep 28, 2022

Conversation

janosg
Copy link
Member

@janosg janosg commented Mar 22, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #294 (afe8569) into main (2ce0b0f) will decrease coverage by 0.28%.
The diff coverage is 87.71%.

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   92.90%   92.61%   -0.29%     
==========================================
  Files         191      207      +16     
  Lines       15367    16097     +730     
==========================================
+ Hits        14276    14909     +633     
- Misses       1091     1188      +97     
Impacted Files Coverage Δ
tests/visualization/test_profile_plot.py 100.00% <ø> (ø)
...agic/optimization/tranquilo/thourough_subsolver.py 30.00% <30.00%> (ø)
.../estimagic/optimization/tranquilo/filter_points.py 66.66% <66.66%> (ø)
...imagic/optimization/tranquilo/tranquilo_history.py 75.00% <75.00%> (ø)
src/estimagic/optimization/tranquilo/fit_models.py 78.00% <78.00%> (ø)
...timagic/optimization/tranquilo/aggregate_models.py 83.60% <83.60%> (ø)
...timagic/optimization/tranquilo/solve_subproblem.py 88.31% <88.31%> (ø)
.../estimagic/optimization/tranquilo/sample_points.py 89.28% <89.28%> (ø)
src/estimagic/optimization/tranquilo/tranquilo.py 91.79% <91.79%> (ø)
...s/optimization/tranquilo/test_tranquilo_history.py 94.52% <94.52%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@timmens timmens self-requested a review September 27, 2022 13:25
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. I think it will be much easier to work on tranquilo in a bigger team once it is merged into main.

@janosg janosg merged commit 13c02f8 into main Sep 28, 2022
@janosg janosg deleted the tranquilo branch September 28, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants