Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate observations from EPP lecture #416

Merged
merged 11 commits into from
Dec 13, 2022
Merged

Incorporate observations from EPP lecture #416

merged 11 commits into from
Dec 13, 2022

Conversation

janosg
Copy link
Member

@janosg janosg commented Dec 9, 2022

  • Add numba to pip requirements
  • Need a code snippet that shows how to use criterion_plot and params_plot with a results dictionary
  • Document the use of n_gridpoints in slice_plot
  • Make sure the minimum scipy version is high enough to suport sobol sampling. This is version 1.7 from June 2021
    • conda (will be done as part of the release)
    • pip
  • Add bounds support to scipy neldermead (possible since scipy 1.7)

@janosg
Copy link
Member Author

janosg commented Dec 9, 2022

@timmens we get a simoptlib error. Can you look at it? Probably related to this new release

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #416 (416a91f) into main (60e05f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files         222      222           
  Lines       17420    17420           
=======================================
  Hits        16181    16181           
  Misses       1239     1239           
Impacted Files Coverage Δ
src/estimagic/optimization/scipy_optimizers.py 99.04% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mpetrosian mpetrosian merged commit d3cbbab into main Dec 13, 2022
@mpetrosian mpetrosian deleted the epp-feedback branch December 13, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants