Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish poisedness #423

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Polish poisedness #423

merged 1 commit into from
Jan 17, 2023

Conversation

segsell
Copy link
Member

@segsell segsell commented Jan 16, 2023

Mini PR to polish the poisedness module.

  • Remove _get_poisedness_constant_internal
  • Replace _get_minimize_func with _get_minimize_options

@segsell segsell requested a review from janosg January 16, 2023 10:25
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #423 (63c9342) into main (e9d4cd6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   92.86%   92.86%   -0.01%     
==========================================
  Files         225      225              
  Lines       17589    17584       -5     
==========================================
- Hits        16334    16329       -5     
  Misses       1255     1255              
Impacted Files Coverage Δ
src/estimagic/optimization/tranquilo/poisedness.py 100.00% <100.00%> (ø)
tests/optimization/tranquilo/test_poisedness.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janosg janosg merged commit d73393c into main Jan 17, 2023
@janosg janosg deleted the polish branch January 17, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants