Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constraint interface #522

Merged
merged 20 commits into from
Aug 13, 2024
Merged

Update constraint interface #522

merged 20 commits into from
Aug 13, 2024

Conversation

timmens
Copy link
Member

@timmens timmens commented Aug 12, 2024

Update constraints interface according to EEP-02 (changes described here)

  • Also adds some tests for pytree handling in derivatives

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@timmens timmens changed the base branch from main to 0.5.0 August 12, 2024 12:10
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 88.94472% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/optimagic/constraints.py 85.31% 21 Missing ⚠️
...imagic/optimization/create_optimization_problem.py 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/estimagic/estimate_ml.py 82.47% <100.00%> (+0.07%) ⬆️
src/estimagic/estimate_msm.py 89.68% <100.00%> (+0.43%) ⬆️
src/optimagic/__init__.py 100.00% <100.00%> (+8.69%) ⬆️
src/optimagic/deprecations.py 100.00% <100.00%> (ø)
src/optimagic/optimization/optimize.py 91.26% <ø> (-0.17%) ⬇️
src/optimagic/parameters/constraint_tools.py 100.00% <100.00%> (ø)
src/optimagic/parameters/process_constraints.py 96.49% <100.00%> (ø)
src/optimagic/shared/process_user_function.py 98.52% <ø> (ø)
...imagic/optimization/create_optimization_problem.py 86.16% <75.00%> (+0.12%) ⬆️
src/optimagic/constraints.py 85.31% <85.31%> (ø)

... and 2 files with indirect coverage changes

src/estimagic/estimate_ml.py Outdated Show resolved Hide resolved
src/estimagic/estimate_msm.py Outdated Show resolved Hide resolved
src/optimagic/constraints.py Show resolved Hide resolved
src/optimagic/constraints.py Show resolved Hide resolved
src/optimagic/constraints.py Outdated Show resolved Hide resolved
src/optimagic/deprecations.py Outdated Show resolved Hide resolved
tests/optimagic/differentiation/test_derivatives.py Outdated Show resolved Hide resolved
tests/optimagic/test_deprecations.py Show resolved Hide resolved
src/estimagic/estimate_ml.py Outdated Show resolved Hide resolved
src/optimagic/deprecations.py Show resolved Hide resolved
src/optimagic/deprecations.py Show resolved Hide resolved
test.py Outdated Show resolved Hide resolved
Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timmens timmens merged commit 354155d into 0.5.0 Aug 13, 2024
16 checks passed
@timmens timmens deleted the constraint-interface branch August 13, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants