Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10397] replace info log with debug log for Decision flow #390

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

pulak-opti
Copy link
Contributor

Ticket:

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an appropriate solution.

Are the Config settings already handled elsewhere? For example, default to Info to keep the noise lower unless needed for Debug purpose

@pulak-opti
Copy link
Contributor Author

This looks like an appropriate solution.

Are the Config settings already handled elsewhere? For example, default to Info to keep the noise lower unless needed for Debug purpose

Thanks @mikechu-optimizely

Here, users can pass their own logger as it is an interface. Users have to pass the settings in thier server implementation as we have done in our agent. https://github.com/optimizely/agent/blob/de8cb88aef8b75d886631b9324462c9df62b2492/config.yaml#L22

About Info/Debug default, Users can produce the same info log (if needed) after getting the result from the SDK.

@pulak-opti pulak-opti merged commit e152edb into master Aug 2, 2024
13 checks passed
@pulak-opti pulak-opti deleted the pulak/log-review branch August 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants