Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defend against invalid BatchEventProcessor configuration overrides. #331

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Defend against invalid BatchEventProcessor configuration overrides. #331

merged 2 commits into from
Aug 13, 2019

Conversation

mikecdavis
Copy link
Contributor

Summary

  • Reverts to default config values when invalid for BatchEventProcessor.
  • Adds expectedCall count to EventHandlerRule to simplify tests.

aliabbasrizvi
aliabbasrizvi approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

core-api/src/main/java/com/optimizely/ab/event/BatchEventProcessor.java
public Builder withBatchSize(Integer batchSize) {
this.batchSize = batchSize;
return this;
}

/**
* FlushInterval is the maximum duration, in milliseconds, that an event will remain in flight before
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. May be say event will remain in queue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to confuse the pending batch with the eventQueue. There are no guarantees about how long an event might exist in the eventQueue.

@mikecdavis mikecdavis requested a review from a team as a code owner August 13, 2019 19:14
@mikecdavis mikecdavis merged commit fe68ea5 into master Aug 13, 2019
@mikecdavis mikecdavis deleted the mikecdavis/OASIS-5179-qa-feedback branch August 13, 2019 22:11
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1175

  • 22 of 22 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 89.813%
Totals Coverage Status
Change from base Build 1173: 0.05%
Covered Lines: 3606
Relevant Lines: 4015
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees

@mikecdavis mikecdavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikecdavis @coveralls @aliabbasrizvi