Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require EventHandler in the BatchEventProcessor. #333

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Require EventHandler in the BatchEventProcessor. #333

merged 2 commits into from
Aug 28, 2019

Conversation

mikecdavis
Copy link
Contributor

@mikecdavis mikecdavis commented Aug 27, 2019 •
edited
Loading

Summary

  • Throws exception if EventHandler not supplied.
  • Updates example documentation.

@mikecdavis mikecdavis requested a review from a team as a code owner August 27, 2019 23:19
@coveralls
Copy link

coveralls commented Aug 27, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1190

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 89.818%
Totals Coverage Status
Change from base Build 1185: 0.005%
Covered Lines: 3608
Relevant Lines: 4017
💛 - Coveralls

@mikecdavis mikecdavis changed the title Add default EventHandler to prevent logged NPE. Require EventHandler in the BatchEventProcessor. Aug 28, 2019
aliabbasrizvi
aliabbasrizvi approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecdavis mikecdavis merged commit c3e55ce into master Aug 28, 2019
@mikecdavis mikecdavis deleted the mikecdavis/OASIS-5261 branch August 28, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

Assignees

@mikecdavis mikecdavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikecdavis @coveralls @aliabbasrizvi