-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): refactor batch event processor to use blocking queue poll and take so as not to spin too much. #343
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4ecfce9
need to reset the deadline after it is hit once.
thomaszurkan-optimizely 1b919a3
use flush interval for event queue polling
thomaszurkan-optimizely 48f7fd8
use take if you have timed out enough
thomaszurkan-optimizely 29e2067
refactor to only reset interval in one place.
thomaszurkan-optimizely c64b8d4
remove lambda after discussion with miked
thomaszurkan-optimizely a3fcaa5
fix log message
thomaszurkan-optimizely 78f1cd6
check if deadline is equal or passed since we set timeout at deadline
thomaszurkan-optimizely File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -133,12 +133,14 @@ public void run() { | |
if (System.currentTimeMillis() > deadline) { | ||
logger.debug("Deadline exceeded flushing current batch."); | ||
flush(); | ||
deadline = System.currentTimeMillis() + flushInterval; | ||
} | ||
|
||
Object item = eventQueue.poll(50, TimeUnit.MILLISECONDS); | ||
Object item = eventQueue.poll(flushInterval, TimeUnit.MILLISECONDS); | ||
if (item == null) { | ||
logger.debug("Empty item, sleeping for 50ms."); | ||
Thread.sleep(50); | ||
logger.debug("Empty item after waiting flush interval. Flushing."); | ||
flush(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This flush() is not necessary since it will be captured on the next |
||
deadline = System.currentTimeMillis() + flushInterval; | ||
continue; | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this another configuration option. If we set to
flushInterval
then the messages are only guaranteed to be dispatched every (2 * flushInterval) milliseconds. I'd like to better understand the CPU and battery utilization with a change like this.