Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore): release off of master #347

Merged
merged 1 commit into from
Nov 15, 2019
Merged

(chore): release off of master #347

merged 1 commit into from
Nov 15, 2019

Conversation

thomaszurkan-optimizely
Copy link
Contributor

Summary

  • Catching some PRs we missed.

@coveralls
Copy link

coveralls commented Nov 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1248

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.679%
Totals Coverage Status
Change from base Build 1242: 0.0%
Covered Lines: 18030
Relevant Lines: 20105
💛 - Coveralls

mikeproeng37
mikeproeng37 approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 13c27ff into master Nov 15, 2019
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the release3.3.4OffOfMaster branch November 15, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@mikecdavis mikecdavis Awaiting requested review from mikecdavis

Assignees

@thomaszurkan-optimizely thomaszurkan-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaszurkan-optimizely @coveralls @mikeproeng37