Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refact: Removed usage of stream from optimizelyConfig service to support android api 21 and 22 #357

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Refact: Removed usage of stream from optimizelyConfig service to support android api 21 and 22 #357

merged 2 commits into from
Jan 30, 2020

Conversation

mnoman09
Copy link
Contributor

Summary

  • Removed Java 8 supported functions to support android api 21 and 22

@mnoman09 mnoman09 requested a review from a team as a code owner January 29, 2020 14:15
@coveralls
Copy link

coveralls commented Jan 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1343

  • 68 of 68 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 89.354%
Totals Coverage Status
Change from base Build 1341: 0.08%
Covered Lines: 3777
Relevant Lines: 4227
💛 - Coveralls

jaeopt
jaeopt approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a variable name change suggestion

core-api/src/main/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfigService.java
getVariationsMap(experiment.getVariations(), experiment.getId())
));
}
return featureExperimentMap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"featureExperimentMap" can mislead. Change it to "experimentsMap" or "experimentKeyMap"

@msohailhussain msohailhussain requested a review from a team January 29, 2020 22:22
thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikecdavis
mikecdavis approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jaeopt jaeopt merged commit b9a150b into master Jan 30, 2020
@jaeopt jaeopt deleted the mnoman/refact-OptlyConfig branch January 30, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecdavis mikecdavis mikecdavis approved these changes

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnoman09 @coveralls @mikecdavis @thomaszurkan-optimizely @jaeopt