Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ForcedDecision): remove config-ready check from forced-decision apis #454

Merged
merged 2 commits into from
Dec 3, 2021
Merged

fix(ForcedDecision): remove config-ready check from forced-decision apis #454

merged 2 commits into from
Dec 3, 2021

Conversation

The-inside-man
Copy link
Contributor

Summary

  • Remove config-ready check from forced-decision apis

Test plan

  • Unit and FSC tests

@coveralls
Copy link

coveralls commented Dec 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1907

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 90.731%
Files with Coverage Reduction New Missed Lines %
core-api/src/main/java/com/optimizely/ab/Optimizely.java 2 93.88%
Totals Coverage Status
Change from base Build 1898: 0.02%
Covered Lines: 4865
Relevant Lines: 5362
💛 - Coveralls

@The-inside-man The-inside-man marked this pull request as ready for review December 3, 2021 17:59
@The-inside-man The-inside-man requested a review from a team as a code owner December 3, 2021 18:00
jaeopt
jaeopt approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@The-inside-man The-inside-man merged commit 80ab3f0 into master Dec 3, 2021
@The-inside-man The-inside-man deleted the jbrown/fd-update branch December 3, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@The-inside-man The-inside-man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@The-inside-man @coveralls @jaeopt