Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9432] fix: fix to support arbitrary client names to be included in logx and odp events. #524

Merged
merged 5 commits into from
Jun 26, 2023
Merged

[FSSDK-9432] fix: fix to support arbitrary client names to be included in logx and odp events. #524

merged 5 commits into from
Jun 26, 2023

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Jun 16, 2023 •
edited
Loading

Summary

  1. Fix to support arbitrary client names to be included in logx and odp events.
  • The previous implementation allows only a fixed set of values (java-sdk, android-sdk, and android-tv-sdk) with enum.
  • We need to make it more flexible to support other sdks too (flutter, react-native, etc) wrapping the android-sdk and java-sdk cores.
  • Old methods for enum access are all deprecated.
  1. Downgrade jackson library version down to 2.13.5 (2.14+ uses Java8 langs not supported in Android)

Test plan

Add unit tests for new APIs.
Pass all existing tests.

Issues

  • FSSDK-9432

@jaeopt jaeopt requested a review from a team as a code owner June 16, 2023 00:18
@jaeopt jaeopt removed their assignment Jun 16, 2023
@jaeopt jaeopt requested a review from mnoman09 June 16, 2023 00:20
@jaeopt jaeopt mentioned this pull request Jun 16, 2023
Merged
mnoman09
mnoman09 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit c507649 into master Jun 26, 2023
@jaeopt jaeopt deleted the jae/client-name branch June 26, 2023 22:37
This was referenced Sep 1, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnoman09 mnoman09 mnoman09 approved these changes

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @mnoman09 @optimizely-codereview-bot