Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9105] Fix: Added proguard rules to resolve "no serializer found" error #51

Merged
merged 2 commits into from
May 4, 2023
Merged

[FSSDK-9105] Fix: Added proguard rules to resolve "no serializer found" error #51

merged 2 commits into from
May 4, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented May 4, 2023 •
edited
Loading

Summary

  • "no serializer found" error is resolved by adding proguard rules.

Test plan

All tests should pass.

Issues

@mnoman09 mnoman09 changed the title Fix: Added proguard rules to resolve "no serializer found" error [FSSDK-9105] Fix: Added proguard rules to resolve "no serializer found" error May 4, 2023
@yasirfolio3 yasirfolio3 requested a review from jaeopt May 4, 2023 16:37
jaeopt

This comment was marked as outdated.

Sign in to view

jaeopt
jaeopt requested changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to build in release but the proguard in the sdk is not reflected properly. Can you double check?

jaeopt
jaeopt approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I was testing with a wrong branch. It works beautifully :)

@mnoman09 mnoman09 merged commit 4d9468f into master May 4, 2023
@mnoman09 mnoman09 deleted the mnoman/FSSDK-9105 branch May 4, 2023 20:13
mikechu-optimizely pushed a commit that referenced this pull request May 8, 2023
@mnoman09 @mikechu-optimizely
[FSSDK-9105] Fix: Added proguard rules to resolve "no serializer foun…
fdf4bd2 
…d" error (#51)

* Added proguard rules

* nit fix

---------

Co-authored-by: NomanShoaib <[email protected]>
(cherry picked from commit 4d9468f)
@TannerLessen TannerLessen mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @jaeopt @NomanShoaib