Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9430] feat: add configurable log level support #63

Merged
merged 9 commits into from
Jun 16, 2023
Merged

Conversation

jaeopt
Copy link
Collaborator

@jaeopt jaeopt commented Jun 14, 2023

Summary

Clients can control default log-level of native swift-sdk and android-sdk with a parameter value when initializing SDK.

  • swift-adk already supports configurable log-level.
  • android-sdk does not support configurable log-level programmatically. A global slf4j log-level control added into the android plugin wrapper.

Example: OptimizelyFlutterSDK(defaultLogLevel: OptimizelyLogLevel.debug)

Test plan

  • add unit tests validating dart log-level propagated to native swift and android-sdk log-level control.

Issues

  • FSSDK-9430
  • FSSDK-9468

Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

android/build.gradle Show resolved Hide resolved
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt closed this Jun 14, 2023
@jaeopt jaeopt reopened this Jun 14, 2023
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit e44524e into master Jun 16, 2023
@jaeopt jaeopt deleted the jae/log-level branch June 16, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants