Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9592] fix proguard for logback and dart version #68

Merged
merged 1 commit into from
Jan 10, 2024
Merged

[FSSDK-9592] fix proguard for logback and dart version #68

merged 1 commit into from
Jan 10, 2024

Conversation

jaeopt
Copy link
Collaborator

@jaeopt jaeopt commented Dec 20, 2023

Summary

  • add proguard rule for logback (crashes in release mode)
  • change the dart version requirements to 4.0

These fixes are not directly related to FSSDK-9582. Issues found while working on the ticket.

Test plan

  • Manual testing with release build (validate obfuscating)

Issues

muzahidul-opti
muzahidul-opti approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@muzahidul-opti muzahidul-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 0f4a6eb into master Jan 10, 2024
9 checks passed
@muzahidul-opti muzahidul-opti deleted the jae/dart-version branch January 10, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muzahidul-opti muzahidul-opti muzahidul-opti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaeopt @muzahidul-opti