Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9358] chore: add flutter specific client name support to track event #72

Merged
merged 8 commits into from
Jan 26, 2024
Merged

[FSSDK-9358] chore: add flutter specific client name support to track event #72

merged 8 commits into from
Jan 26, 2024

Conversation

muzahidul-opti
Copy link
Contributor

Summary

  • Client name and version added to track the event sent by flutter sdk.

Test plan

  • All previous tests should be passed.

Issues

@muzahidul-opti muzahidul-opti marked this pull request as ready for review January 25, 2024 17:18
jaeopt
jaeopt previously approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we double check -

  1. logx handles those new client names with "/" ok.
  2. iOS privacy file is handled ok in flutter sdk too when building for iOS.

lib/package_info.dart Show resolved Hide resolved
lib/src/optimizely_client_wrapper.dart Outdated Show resolved Hide resolved
lib/src/utils/utils.dart Outdated Show resolved Hide resolved
@muzahidul-opti
Copy link
Contributor Author

Member

Looks good! Can we double check -

  1. logx handles those new client names with "/" ok.
  2. iOS privacy file is handled ok in flutter sdk too when building for iOS.
  1. Got some data in the report page but can't be able to verify it.
  2. This issue is still open for flutter Determine how to handle privacy manifests in packages flutter/flutter#131940. May be we need to wait for the solution.

@muzahidul-opti muzahidul-opti merged commit 5521cc9 into master Jan 26, 2024
7 of 9 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/client-name-support branch January 26, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @jaeopt