Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending impression event when feature is disabled for variation #114

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Sending impression event when feature is disabled for variation #114

merged 1 commit into from
Jun 19, 2018

Conversation

aliabbasrizvi
Copy link
Contributor

No description provided.

@aliabbasrizvi aliabbasrizvi requested a review from a team June 19, 2018 20:06
@coveralls
Copy link

coveralls commented Jun 19, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 96.877% when pulling 535da63 on ali/fix_send_event_feature_disabled into 1012bbc on master.

@aliabbasrizvi
Copy link
Contributor Author

build

1 similar comment
@aliabbasrizvi
Copy link
Contributor Author

build

@aliabbasrizvi aliabbasrizvi mentioned this pull request Jun 19, 2018
Merged
@aliabbasrizvi
Copy link
Contributor Author

build

mikeproeng37
mikeproeng37 approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@aliabbasrizvi aliabbasrizvi merged commit a4af0d1 into master Jun 19, 2018
@aliabbasrizvi aliabbasrizvi deleted the ali/fix_send_event_feature_disabled branch June 19, 2018 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliabbasrizvi @coveralls @mikeproeng37