Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added "enabled" field to decision metadata structure #217

Merged
merged 3 commits into from
Nov 14, 2020
Merged

feat: added "enabled" field to decision metadata structure #217

merged 3 commits into from
Nov 14, 2020

Conversation

zashraf1985
Copy link
Contributor

Summary

  1. Added "enabled" field to decision metadata structure
  2. Setting "enabled" to true for activate() since we check for non null variation.

Test Plan

  1. Manuall tested thoroughly
  2. Fixed existing unit tests

@zashraf1985 zashraf1985 requested a review from a team as a code owner November 10, 2020 01:47
@zashraf1985 zashraf1985 removed their assignment Nov 10, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 97.521% when pulling c59e4cd on zeeshan/add-enabled-to-metadata into 04f5300 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 97.521% when pulling c59e4cd on zeeshan/add-enabled-to-metadata into 04f5300 on master.

@coveralls
Copy link

coveralls commented Nov 10, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.004%) to 98.14% when pulling a9c1cbe on zeeshan/add-enabled-to-metadata into 04f5300 on master.

pawels-optimizely
pawels-optimizely reviewed Nov 13, 2020
View reviewed changes
src/Optimizely/Optimizely.php Outdated
@@ -195,10 +195,10 @@ private function validateUserInputs($attributes, $eventTags = null)
* @param array Associative array of user attributes
* @param DatafileProjectConfig DatafileProjectConfig instance
*/
protected function sendImpressionEvent($config, $experimentKey, $variationKey, $flagKey, $ruleKey, $ruleType, $userId, $attributes)
protected function sendImpressionEvent($config, $experimentKey, $variationKey, $flagKey, $ruleKey, $ruleType, $userId, $attributes, $enabled)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add enabled before userID ? (after ruleType, that way we group them together)

@zashraf1985 zashraf1985 reopened this Nov 13, 2020
@pawels-optimizely pawels-optimizely merged commit 878fc64 into master Nov 14, 2020
@pawels-optimizely pawels-optimizely deleted the zeeshan/add-enabled-to-metadata branch November 14, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

Assignees

@zashraf1985 zashraf1985

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zashraf1985 @coveralls @pawels-optimizely @optimizely-codereview-bot