-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(OptimizelyConfig): Add new fields to OptimizelyConfig #230
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
df67724
config v2 implementation
ozayr-zaviar c56a186
removed decoder package
ozayr-zaviar 4176c4b
deprecation warning added
ozayr-zaviar b67e2d1
typo corrected
ozayr-zaviar 563003b
comments addressed
ozayr-zaviar ccda595
extra spacing removed
ozayr-zaviar 1df4ab0
testcases comments addressed
ozayr-zaviar 8d23eeb
lint fixed
ozayr-zaviar 5304778
comments addressed
ozayr-zaviar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
<?php | ||
/** | ||
* Copyright 2021, Optimizely Inc and Contributors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
namespace Optimizely\OptimizelyConfig; | ||
|
||
class OptimizelyAttribute implements \JsonSerializable | ||
{ | ||
/** | ||
* @var string id representing attribute. | ||
*/ | ||
private $id; | ||
|
||
/** | ||
* @var string key representing attribute. | ||
*/ | ||
private $key; | ||
|
||
public function __construct($id, $key) | ||
{ | ||
$this->id = $id; | ||
$this->key = $key; | ||
} | ||
|
||
/** | ||
* @return string attribute id. | ||
*/ | ||
public function getId() | ||
{ | ||
return $this->id; | ||
} | ||
|
||
/** | ||
* @return string attribute key. | ||
*/ | ||
public function getKey() | ||
{ | ||
return $this->key; | ||
} | ||
|
||
/** | ||
* @return string JSON representation of the object. | ||
*/ | ||
public function jsonSerialize() | ||
{ | ||
return get_object_vars($this); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
<?php | ||
/** | ||
* Copyright 2021, Optimizely Inc and Contributors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
namespace Optimizely\OptimizelyConfig; | ||
|
||
class OptimizelyAudience implements \JsonSerializable | ||
{ | ||
/** | ||
* @var string representing audience id. | ||
*/ | ||
private $id; | ||
|
||
/** | ||
* @var string representing audience name . | ||
*/ | ||
private $name; | ||
|
||
/** | ||
* @var string conditions representing audience conditions. | ||
*/ | ||
private $conditions; | ||
|
||
|
||
public function __construct($id, $name, $conditions) | ||
{ | ||
$this->id = $id; | ||
$this->name = $name; | ||
$this->conditions = $conditions; | ||
} | ||
|
||
/** | ||
* @return string audience id. | ||
*/ | ||
public function getId() | ||
{ | ||
return $this->id; | ||
} | ||
|
||
/** | ||
* @return string audience name. | ||
*/ | ||
public function getName() | ||
{ | ||
return $this->name; | ||
} | ||
|
||
/** | ||
* @return string audience conditions. | ||
*/ | ||
public function getConditions() | ||
{ | ||
return $this->conditions; | ||
} | ||
|
||
/** | ||
* @return string JSON representation of the object. | ||
*/ | ||
public function jsonSerialize() | ||
{ | ||
return get_object_vars($this); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't understand why these are removed from here. all three.