FIX: Forced variation not available in experiment #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -251,10 +251,9 @@ public function createImpressionEvent($config, $experimentId, $variationKey, $fl | |||
| { | |||
| $eventParams = $this->getCommonParams($config, $userId, $attributes); | |||
| $experiment = $config->getExperimentFromId($experimentId); | |||
| $variation = $config->getFlagVariationByKey($flagKey, $variationKey); | |||
There was a problem hiding this comment.
Please add a comment above this line that mapped flagKey can be directly used in variation so no experimentKey exist.
jaeopt
requested changes
Dec 16, 2021
| @@ -251,10 +251,9 @@ public function createImpressionEvent($config, $experimentId, $variationKey, $fl | |||
| { | |||
| $eventParams = $this->getCommonParams($config, $userId, $attributes); | |||
| $experiment = $config->getExperimentFromId($experimentId); | |||
| $variation = $config->getFlagVariationByKey($flagKey, $variationKey); | |||
There was a problem hiding this comment.
It looks like we need check empty both 'flagKey' (line 256) and 'experimentId' (line 260).
Also consider switching line 260 and 256 since 256 is common cases while 256 is for FD only and slow.
…and then checking $variation = $config->getFlagVariationByKey($flagKey, $variationKey);
jaeopt
requested changes
Dec 20, 2021
| @@ -251,10 +251,9 @@ public function createImpressionEvent($config, $experimentId, $variationKey, $fl | |||
| { | |||
| $eventParams = $this->getCommonParams($config, $userId, $attributes); | |||
| $experiment = $config->getExperimentFromId($experimentId); | |||
| $variation = $config->getFlagVariationByKey($flagKey, $variationKey); | |||
There was a problem hiding this comment.
We also need a unit test covering this bug?
|
@mnoman09 ah ok, I was confused. all looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All unit test and FSC tests should pass