Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: header updated. #247

Merged
merged 1 commit into from
May 12, 2022
Merged

fix: header updated. #247

merged 1 commit into from
May 12, 2022

Conversation

msohailhussain
Copy link
Contributor

Summary

#243 header was not updated, updating in this PR.

Test plan

Should pass all scenarios and unit tests.

@msohailhussain msohailhussain requested a review from a team as a code owner May 12, 2022 20:07
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.292% when pulling fa35e06 on sohail/updatecheader into 95cea9b on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.292% when pulling fa35e06 on sohail/updatecheader into 95cea9b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.292% when pulling fa35e06 on sohail/updatecheader into 95cea9b on master.

@coveralls
Copy link

coveralls commented May 12, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.007%) to 97.781% when pulling fa35e06 on sohail/updatecheader into 95cea9b on master.

@msohailhussain msohailhussain removed their assignment May 12, 2022
@msohailhussain msohailhussain merged commit 7fc037d into master May 12, 2022
@msohailhussain msohailhussain deleted the sohail/updatecheader branch May 12, 2022 22:27
Mat001
Mat001 reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 left review comments

@zashraf1985 zashraf1985 zashraf1985 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msohailhussain @coveralls @Mat001 @zashraf1985