[FSSDK-10730] isClientReady logic adjustment (#285)

React SDK sets client.isClientReady property to true immediately if datafile presents in the config, before projectConfigManager gets ready, which should not be the case.
optimizely · Oct 4, 2024 · f3185b7 · f3185b7 · github-actions · Oct 4, 2024
1 parent 1197fb2
commit f3185b7
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/client.ts b/src/client.ts
@@ -240,7 +240,7 @@ class OptimizelyReactSDKClient implements ReactSDKClient {
     });
 
     this._client = optimizely.createInstance(configWithClientInfo);
-    this.isClientReady = !!configWithClientInfo.datafile;
+    this.isClientReady = !!this.getOptimizelyConfig();
     this.isUsingSdkKey = !!configWithClientInfo.sdkKey;
 
     if (this._client) {
@@ -250,8 +250,7 @@ class OptimizelyReactSDKClient implements ReactSDKClient {
         ([userResult, clientResult]) => {
           this.isClientReady = clientResult.success;
           this.isUserReady = userResult.success;
-          const clientAndUserReady = this.isClientReady && this.isUserReady;
-
+          const clientAndUserReady = this.isReady();
           this.clientAndUserReadyPromiseFulfilled = true;
 
           return {