Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9969] replace uglify plugin with terser #248

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[FSSDK-9969] replace uglify plugin with terser #248

merged 1 commit into from
Mar 5, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

  • rollup-plugin-uglify has not been updated since 2019 and the last version has vulnerable dependencies causing dependabot alerts. Replaced this with terser plugin instead.

Test plan

Issues

  • FSSDK-9969

mikechu-optimizely
mikechu-optimizely approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 🙏

@raju-opti raju-opti merged commit f02a720 into master Mar 5, 2024
7 checks passed
@raju-opti raju-opti deleted the raju/uglify branch March 5, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raju-opti @mikechu-optimizely