Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-10437] jest coverage report job addition #281

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

junaed-optimizely
Copy link
Contributor

Summary

Test coverage report job added

Test plan

Existing test should pass

Issues

Copy link

github-actions bot commented Sep 10, 2024

Code Coverage Report

St.
Category Percentage Covered / Total
🟢 Statements 98.95% 847/856
🟢 Branches 91.64% 340/371
🟢 Functions 97.52% 157/161
🟢 Lines 99.09% 765/772

Test suite run success

258 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from 29f939a

@junaed-optimizely junaed-optimizely marked this pull request as ready for review September 10, 2024 13:09
Copy link

github-actions bot commented Sep 10, 2024

Jest Coverage Report

St.
Category Percentage Covered / Total
🟢 Statements 98.95% 847/856
🟢 Branches 91.64% 340/371
🟢 Functions 97.52% 157/161
🟢 Lines 99.09% 765/772

Test suite run success

258 tests passing in 10 suites.

Report generated by 🧪jest coverage report action from 6fed881

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

ArtiomTr/jest-coverage-report-action looks like a good and active project.

Part of me wishes we could collect the --coverage only on the last matrix run (20; currently), then if 1 additional step to unitTests to publish the report. ...but then I'm just over-engineering for the sake of a 1 additional run.

.github/workflows/react.yml Show resolved Hide resolved
@junaed-optimizely junaed-optimizely merged commit 80e4d2c into master Sep 10, 2024
12 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10437-enable-coverage-report branch September 10, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants