Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send flag decisions #272

Merged
merged 2 commits into from
Oct 21, 2020
Merged

feat: send flag decisions #272

merged 2 commits into from
Oct 21, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Oct 12, 2020

Summary

  • Dispatches event when rollout and send_flag_deciions flag is True
  • Dispatches event when variation is nil ( neither feature-test nor rollout) and send_flag_decisions is True
  • Adds metadata to impression event.

Test plan

  • Fixed All Unit tests
  • Verified Manually with FSC Flag Decisions Tests

Issues

@oakbani oakbani requested a review from a team as a code owner October 12, 2020 15:47
pawels-optimizely
pawels-optimizely suggested changes Oct 12, 2020
View reviewed changes
lib/optimizely.rb Outdated Show resolved Hide resolved
spec/project_spec.rb Outdated Show resolved Hide resolved
spec/project_spec.rb Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Oct 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 99.6% when pulling 6dabe7e on oakbani/flag-decision into dc2088d on master.

@oakbani oakbani removed their assignment Oct 13, 2020
@oakbani
Copy link
Contributor Author

oakbani commented Oct 13, 2020

@pawels-optimizely As discussed,

  • now activate will pass empty string for flag key
  • is_feature_enabled will pass empty string for rule key and variation key and rollout in rule type when variation is nil.

msohailhussain
msohailhussain approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oakbani oakbani removed their assignment Oct 15, 2020
pawels-optimizely
pawels-optimizely approved these changes Oct 20, 2020
View reviewed changes
Copy link

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pawels-optimizely
pawels-optimizely suggested changes Oct 20, 2020
View reviewed changes
Copy link

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address my comments

pawels-optimizely
pawels-optimizely approved these changes Oct 21, 2020
View reviewed changes
Copy link

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx for addressing the comments

@pawels-optimizely pawels-optimizely merged commit b97c41e into master Oct 21, 2020
@pawels-optimizely pawels-optimizely deleted the oakbani/flag-decision branch October 21, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

@thomaszurkan-optimizely thomaszurkan-optimizely Awaiting requested review from thomaszurkan-optimizely

Assignees

@oakbani oakbani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oakbani @coveralls @msohailhussain @pawels-optimizely @optimizely-codereview-bot